This repository was archived by the owner on May 12, 2026. It is now read-only.
refactor: xna2bids schema #104
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,9 @@ | ||
| // Import Bulma's core | ||
| @import "~bulma/sass/utilities/functions"; | ||
|
|
||
| // Set colors, overrides etc.. | ||
| @import "variables"; | ||
|
|
||
| // Import Bulma and Buefy styles | ||
| @import "~bulma"; | ||
| @import "~buefy/src/scss/buefy"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <template> | ||
| <fragment> | ||
| <b-field> | ||
| <b-switch | ||
| v-model="value.required" | ||
| type="is-info" | ||
| @input="updateValue('required', $event)" | ||
| >Needs bidsmap file</b-switch | ||
| > | ||
| </b-field> | ||
| <b-field | ||
| v-if="value.required" | ||
| label="Directory containing the bidsmap file" | ||
| > | ||
| <b-input | ||
| v-model="value.dir" | ||
| @input="updateValue('dir', $event)" | ||
| ></b-input> | ||
| </b-field> | ||
| <b-field v-if="value.required" label="Bidsmap file"> | ||
| <b-input | ||
| v-model="value.file" | ||
| @input="updateValue('file', $event)" | ||
| ></b-input> | ||
| </b-field> | ||
| </fragment> | ||
| </template> | ||
|
|
||
| <script> | ||
| export default { | ||
| props: { | ||
| value: { | ||
| type: Object, | ||
| required: true, | ||
| }, | ||
| }, | ||
| methods: { | ||
| updateValue(key, val) { | ||
| this.value[key] = val | ||
| this.$emit('f-bidsmap', this.value) | ||
| }, | ||
|
Comment on lines
+38
to
+41
There was a problem hiding this comment. The combination of |
||
| }, | ||
| } | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| <template> | ||
| <div class="card-content"> | ||
| <div v-for="(session, index) in value" :key="index" class="content"> | ||
| <b-notification :closable="false"> | ||
| <b-field type="is-warning"> | ||
| <p class="control"> | ||
| <span class="button is-static is-link">Participant ID</span> | ||
| </p> | ||
| <b-input | ||
| :value="session.participant_id" | ||
| placeholder="135" | ||
| @input="updateValue(index, 'participant_id', $event)" | ||
| /> | ||
| </b-field> | ||
| <b-field type="is-warning" message="Required"> | ||
| <p class="control"> | ||
| <span class="button is-static">XNAT ACCESSION #</span> | ||
| </p> | ||
| <b-input | ||
| v-model="session.xnat_id" | ||
| placeholder="XNAT3_E00013" | ||
| @input="updateValue(index, 'xnat_id', $event)" | ||
| /> | ||
| </b-field> | ||
| <b-field label="Include series (empty= ALL series)"> | ||
| <b-taginput | ||
| v-model="session.i_series" | ||
| ellipsis | ||
| icon="label" | ||
| placeholder="Add a series number" | ||
| aria-close-label="Delete this tag" | ||
| @input="updateValue(index, 'i_series', $event)" | ||
| > | ||
| </b-taginput> | ||
| </b-field> | ||
| <b-field label="Exclude series"> | ||
| <b-taginput | ||
| v-model="session.s_series" | ||
| ellipsis | ||
| icon="label" | ||
| placeholder="Add a series number" | ||
| aria-close-label="Delete this tag" | ||
| @input="updateValue(index, 's_series', $event)" | ||
| > | ||
| </b-taginput> | ||
| </b-field> | ||
| </b-notification> | ||
| </div> | ||
| <b-button type="is-link" outlined @click="addSession">Add Session</b-button> | ||
| <b-button | ||
| v-if="value.length > 1" | ||
| type="is-link" | ||
| outlined | ||
| @click="removeSession" | ||
| >Remove Session</b-button | ||
| > | ||
| </div> | ||
| </template> | ||
|
|
||
| <script> | ||
| import { mapMutations } from 'vuex' | ||
|
|
||
| export default { | ||
| props: { | ||
| value: { | ||
| type: Array, | ||
| required: true, | ||
| }, | ||
| }, | ||
| methods: { | ||
| ...mapMutations({ | ||
| addSession: 'xnat2bids/addSession', | ||
| removeSession: 'xnat2bids/popSession', | ||
| }), | ||
| updateValue(index, key, val) { | ||
| this.value[index][key] = val | ||
|
There was a problem hiding this comment. You're updating the prop directly here from the child. Are you experiencing any issue here? I would have thought that you needed to emit the value and then set the prop in the parent component. Maybe @mcmcgrath13 ? There was a problem hiding this comment. Yeah, directly updating a prop can cause an infinite render loop. Generally emitting and updating the parent is the safer bet. |
||
| this.$emit('f-sessions', this.value) | ||
| }, | ||
| }, | ||
| } | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,189 +1,32 @@ | ||
| <template> | ||
| <div> | ||
| <vue-form-json-schema | ||
| v-model="xnat2bids" | ||
| :schema="schema" | ||
| :ui-schema="uiSchema" | ||
| ></vue-form-json-schema> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script> | ||
| import { mapFields } from 'vuex-map-fields' | ||
| import VueFormJsonSchema from 'vue-form-json-schema' | ||
| import Xnat2BidsUISchema from '~/data/xnat2bids_ui_schema.json' | ||
| import Xnat2BidsSchema from '~/data/basejob_schema.json' | ||
|
|
||
| export default { | ||
| components: { | ||
| 'vue-form-json-schema': VueFormJsonSchema, | ||
| }, | ||
| data() { | ||
| return { | ||
| isOpen: 0, | ||
| schema: Xnat2BidsSchema, | ||
| uiSchema: Xnat2BidsUISchema, | ||
| } | ||
| }, | ||
| computed: { | ||
| ...mapFields(['xnat2bids']), | ||
| }, | ||
| } | ||
| </script> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
required: falseis the default but it's alright that you include this!