Skip to content

feat(roster): add missing primitive skills (bookkeeping/persist/dogfood) + fix kg P6 mistag (BRO-1586)#82

Merged
broomva merged 1 commit into
mainfrom
chore/bro-1586-roster-add-primitives
Jun 29, 2026
Merged

feat(roster): add missing primitive skills (bookkeeping/persist/dogfood) + fix kg P6 mistag (BRO-1586)#82
broomva merged 1 commit into
mainfrom
chore/bro-1586-roster-add-primitives

Conversation

@broomva

@broomva broomva commented Jun 29, 2026

Copy link
Copy Markdown
Owner

BRO-1586 — add the missing primitive implementations to the roster

Follow-up to #81. The roster claimed to be the bstack-stack but omitted core primitive implementations. Careful curation pass — 56 → 61 entries, all broomva/skills, descriptions taken from each skill's real frontmatter:

Skill category primitive required
bookkeeping knowledge P6 ✅ (universal knowledge engine)
persist orchestration P12 ✅ (Persistent Loop Discipline)
dogfood lifecycle P11 ✅ (Empirical feedback / Dogfood)
skillify meta optional (skill-creation gate)
checkit knowledge optional (role-x/P17 lens)

Fix: kg's P6 mistag

kg was tagged primitive: P6, but P6 is Bookkeepingbookkeeping's own frontmatter declares primitive: P6, and kg's own description says it "pairs with bookkeeping's cmd_index." Dropped kg's primitive tag → one canonical P6 = bookkeeping. kg stays required/knowledge.

Scope (deliberate)

Not added: agentic-vps, architecture-design-principles, broomva-cli, design-engineering, colombia-conflict — general capability skills, not bstack-native primitives/core. skills-roster.md not row-mirrored (its banner already makes the YAML authoritative + itself a broader catalog; the doc uses global numbering, so a 5-row insert would force a fragile renumber).

Validated

  • schema-valid · no duplicate primitive tags (P6/P11/P12 each → exactly one) · no dup names
  • drift-guard remote resolution: all 61 resolve in broomva/skills
  • installer uses --skill <name> for all 61 (bstack-skills list shows the new tags correctly)

🤖 Generated with Claude Code

… mistag (BRO-1586)

The roster claimed to be the bstack-stack but omitted core primitive
implementations. Careful curation pass (56 → 61 entries, all broomva/skills,
descriptions from each skill's real frontmatter):
- bookkeeping  — knowledge,    primitive P6,  required (universal knowledge engine)
- persist      — orchestration, primitive P12, required (Persistent Loop Discipline)
- dogfood      — lifecycle,     primitive P11, required (Empirical feedback / Dogfood)
- skillify     — meta,          optional       (skill-creation gate + skillify_check)
- checkit      — knowledge,     optional       (ingest-and-integrate; a role-x/P17 lens)

Fix: kg was mis-tagged primitive: P6. P6 is Bookkeeping (bookkeeping's own
frontmatter declares P6; kg's description says it 'pairs with bookkeeping's
cmd_index'). Dropped kg's primitive tag → one canonical P6 = bookkeeping. kg
stays required/knowledge.

Deliberately NOT added (general capability skills, not bstack-native primitives):
agentic-vps, architecture-design-principles, broomva-cli, design-engineering,
colombia-conflict. skills-roster.md not row-mirrored — its banner already makes
companion-skills.yaml authoritative and itself a broader catalog.

Validated: schema · no duplicate primitive tags (P6/P11/P12 each →1) · no dup names
· drift-guard remote resolution (all 61 resolve in broomva/skills) · installer uses
--skill <name> for all 61.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@broomva, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 37 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d32ad243-71e6-43ec-9da0-3ee27197261e

📥 Commits

Reviewing files that changed from the base of the PR and between bd239b9 and c78698a.

📒 Files selected for processing (1)
  • references/companion-skills.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bro-1586-roster-add-primitives

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@broomva broomva merged commit 347a152 into main Jun 29, 2026
5 checks passed
@broomva broomva deleted the chore/bro-1586-roster-add-primitives branch June 29, 2026 02:20
broomva added a commit to broomva/skills that referenced this pull request Jun 29, 2026
…ng skills (#72)

P20 review of broomva/bstack#82 (BRO-1586) noted that only bookkeeping carried a
machine-readable 'primitive:' frontmatter field — persist/dogfood/p9/role-x/
cross-review declared their bstack primitive in prose only, so the bstack roster's
primitive tag couldn't be machine-validated against the source. Add the field
(an established Broomva frontmatter extension per CONTRIBUTING):
  persist → P12 · dogfood → P11 · p9 → P9 · role-x → P17 · cross-review → P20
(bookkeeping already had P6). Now every roster primitive tag matches the skill's
own self-declaration. Frontmatter-only; name/description unchanged; lint-skill-md
conforms.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant