Skip to content

Add dummy file to allow bundler to require the gem correctly.#153

Closed
seuros wants to merge 2 commits into
brianmario:masterfrom
seuros:master
Closed

Add dummy file to allow bundler to require the gem correctly.#153
seuros wants to merge 2 commits into
brianmario:masterfrom
seuros:master

Conversation

@seuros

@seuros seuros commented Feb 4, 2015

Copy link
Copy Markdown

No description provided.

@brianmario

Copy link
Copy Markdown
Owner

Hey @seuros, thanks for the patch! I need to think on it a bit because we were planning on renaming the gem to just yajl but I/we haven't had time to actually make it happen.

@sferik what do you think about this vs the rename? I think I kinda prefer the rename over allowing it be required by it's current name. And I said "vs" because if we allow this and people start requiring it by this, we'll have to leave it in. May not be a bad thing though to make it JustWork with Bundler in either case.

@seuros

seuros commented Feb 4, 2015

Copy link
Copy Markdown
Author

@brianmario we won't have to leave the file if we rename it in the future. Since the renaming won't be silent upgrade, it the responsibility of the dev to rename any require pointing to old name.

@brianmario

Copy link
Copy Markdown
Owner

@seuros yeah that's true. Especially if it's just being done in the Gemfile. My concern is for apps that just include it deeper within the stack. Still probably fine.

@sferik

sferik commented Feb 5, 2015

Copy link
Copy Markdown
Contributor

@sferik what do you think about this vs the rename? I think I kinda prefer the rename over allowing it be required by it's current name. And I said "vs" because if we allow this and people start requiring it by this, we'll have to leave it in.

Agreed. IMHO, #128 is a cleaner solution to this problem.

I need to think on it a bit because we were planning on renaming the gem to just yajl but I/we haven't had time to actually make it happen.

What’s holding this up? Is there anything more I can do to make it happen faster?

@seuros Would renaming the gem be an acceptable solution to you?

@seuros seuros closed this Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants