feat: stretch app-list picker tap targets to the trailing button - #75
Merged
Merged
Conversation
In the rule editor's app-list picker, the selection hit area previously covered only the checkmark and text, leaving the gap before the trailing Edit/View button untappable. The toggle button label now stretches across the whole row (.frame(maxWidth: .infinity, minHeight: 44) + .contentShape(Rectangle()), mirroring DayOfWeekPicker) so tapping the title, description, or anywhere left of the button toggles selection, and the row exposes its checked state as the .isSelected accessibility trait for VoiceOver and the UI suite. UI test taps the title and the previous dead zone to verify toggling both ways, and asserts the 44pt minimum height and span to the Edit button. Co-Authored-By: opencode-go (GLM, via opencode) <noreply@opencode.ai>
Make the manual-UI-validation workflow bullet explicit about the mechanism (RenderPreview snapshot or DeviceInteraction run with screenshot inspection) so agents don't stop at passing tests. Co-Authored-By: opencode-go (GLM, via opencode) <noreply@opencode.ai>
The stretched row frame defaulted to center alignment, floating the checkbox and text inward and showing a gap before each checkbox. Anchor the frame to .leading so content sits at the standard list inset while the 44pt tap target still spans the row. Co-Authored-By: opencode-go (GLM, via opencode) <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the rule editor's app-list picker rows, the selection tap target now spans the whole row left of the trailing Edit/View button — icon, title, description, and the previously dead stretch in between — instead of only the icon+text content.
frame(maxWidth: .infinity, minHeight: 44)+contentShape(Rectangle()), same pattern asDayOfWeekPicker; the trailing Edit/View button stays separately tappable..accessibilityAddTraits(.isSelected)so VoiceOver (and the UI suite) can observe the toggle.AppListLibraryViewupdated to match; new UI test added toAppListUITests.Verification
AppListUITests.testPickerRowTouchTargetExtendsToEditButton: red first (failed on 36.7pt height + dead-span to Edit), green after the change — asserts taping the title toggles selection, tapping the previous dead zone toggles it back, height ≥ 44pt, and the row's maxX reaches the Edit button's minX.AppListUITestssuite: 15/15 pass; full UI suite: 59/59 pass; full unit suite: 380 tests pass (iPhone 17 Pro simulator, iOS 26.5).Co-Authored-By: opencode-go (GLM, via opencode) noreply@opencode.ai