Skip to content

Let Bref Cloud find the error of a failed serverless deploy #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 1 commit into from
Sep 28, 2026
Merged

Let Bref Cloud find the error of a failed serverless deploy #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 4 additions & 26 deletions src/Components/ServerlessFramework.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,31 +43,28 @@ public function deploy(int $deploymentId, string $environment, array $awsCredent
$oslsPackage = ($input->hasOption('osls4') && $input->getOption('osls4')) ? 'osls@4' : 'osls@3';

$newLogs = '';
$entireSlsOutput = '';

try {

$process = $this->serverlessExec($oslsPackage, 'deploy', $environment, $awsCredentials, $options);
async(function () use ($process, &$newLogs, &$entireSlsOutput) {
async(function () use ($process, &$newLogs) {
while (($chunk = $process->getStdout()->read()) !== null) {
if (empty($chunk)) continue;
foreach (self::IGNORED_LOGS as $ignoredLog) {
if (str_contains($chunk, $ignoredLog)) continue 2;
}
IO::verbose($chunk);
$newLogs .= $chunk;
$entireSlsOutput .= $chunk;
}
});
async(function () use ($process, &$newLogs, &$entireSlsOutput) {
async(function () use ($process, &$newLogs) {
while (($chunk = $process->getStderr()->read()) !== null) {
if (empty($chunk)) continue;
foreach (self::IGNORED_LOGS as $ignoredLog) {
if (str_contains($chunk, $ignoredLog)) continue 2;
}
IO::verbose($chunk);
$newLogs .= $chunk;
$entireSlsOutput .= $chunk;
}
});
// Send logs to Bref Cloud every x seconds
Expand All @@ -91,14 +88,8 @@ public function deploy(int $deploymentId, string $environment, array $awsCredent
$newLogs .= "Error while running 'serverless deploy', deployment failed\n";
IO::writeln("Error while running 'serverless deploy', deployment failed");

// If `npx` is not installed throw a clear error message
if (str_contains($entireSlsOutput, 'npo: command not found')) {
$brefCloud->markDeploymentFinished($deploymentId, false, 'NPM is not installed. Please make sure Node and NPM are installed: https://docs.npmjs.com/downloading-and-installing-node-js-and-npm', $newLogs);
return;
}

$errorMessage = $this->findErrorMessageInServerlessOutput($entireSlsOutput);
$brefCloud->markDeploymentFinished($deploymentId, false, 'Serverless Framework error: ' . $errorMessage, $newLogs);
// Bref Cloud finds the error in the logs
$brefCloud->markDeploymentFinished($deploymentId, false, null, $newLogs);
return;
}

Expand Down Expand Up @@ -265,17 +256,4 @@ private function cleanupCfOutputs(mixed $outputs): array

return $result;
}

private function findErrorMessageInServerlessOutput(string $entireSlsOutput): string
{
// Try to find the next line after `Error:\n`
$lines = explode("\n", trim($entireSlsOutput));
foreach ($lines as $i => $line) {
if ($line === 'Error:' && isset($lines[$i + 1])) {
return $lines[$i + 1];
}
}
// Return the last line or fallback to a generic message
return $line ?: 'The "serverless deploy" command failed with an unknown error.';
}
}
Loading