Expose the _X_AMZN_TRACE_ID variable in PHP-FPM too - #2192
Merged
Merged
Conversation
The function and console runtimes set it on every invocation, and the documentation says Bref exposes it on every invocation, but PHP-FPM workers did not receive it. Claude-Session: https://claude.ai/code/session_01Awk33iZ9mDSg1xgSAPkgGK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function and console runtimes set
_X_AMZN_TRACE_IDon every invocation, and the documentation says Bref exposes it on every invocation, but PHP-FPM workers didn't receive it: the trace ID was only available inside theLAMBDA_INVOCATION_CONTEXTJSON. #2189 fixed the same gap forLAMBDA_REQUEST_ID.This passes it to PHP-FPM as a FastCGI parameter, so
$_SERVER['_X_AMZN_TRACE_ID']andgetenv('_X_AMZN_TRACE_ID')work the same in every runtime. Documented infpm-runtime.mdx.Side effect to be aware of: on Lambda, the AWS SDK for PHP reads
_X_AMZN_TRACE_ID(its recursion detection middleware) and sends it as theX-Amzn-Trace-Idheader of AWS API calls. That was already the case in the function and console runtimes (and in AWS's native runtimes); AWS calls made from PHP-FPM now carry it too.Tested on AWS Lambda (
php-84-fpmbehind an HTTP API) with this branch:$_SERVER['_X_AMZN_TRACE_ID']andgetenv('_X_AMZN_TRACE_ID')both return the trace header of the current invocation (Root=1-…;Parent=…;Sampled=0;Lineage=…), the same value asLAMBDA_INVOCATION_CONTEXT'straceId, and it changes on every request, including after PHP-FPM restarts following a timeout.