Enable expose_php in the PHP-FPM test fixture - #2188
Merged
Merged
Conversation
Three FpmHandlerTest cases assert the X-Powered-By header, which PHP only sends when expose_php is on. The Bref layers enable it, but distribution php.ini files ship it off for the FPM SAPI, so the tests failed on a stock Debian or Ubuntu PHP install. Co-authored-by: matthieu <matthieu@mnapoli.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three
FpmHandlerTestcases fail on a stock Debian/Ubuntu PHP install:They assert on the
X-Powered-Byheader, which PHP only sends whenexpose_phpis on. The Breflayers enable it, so the assertion is right about production — but the distribution packages ship
expose_php = Offin/etc/php/<version>/fpm/php.ini(while leaving it on for the CLI SAPI), sothe tests depend on how the host PHP happens to be configured.
Found while setting up a Cloud Agent environment where PHP comes from
ppa:ondrej/php.