Mac support#2
Closed
brandon929 wants to merge 6 commits into
Closed
Conversation
…Updated demo_gradio.py to handle memory checks and model precision based on device type. Modified memory.py to support MPS with fixed memory estimates. Adjusted hunyuan_video_packed.py to create tensors on the same device as input. Updated README.md for clearer installation instructions for CUDA and MPS.
…ls.py with new resolution options - Introduced `--output_dir` argument in demo_gradio.py for customizable output folder. - Adjusted image processing resolution to 480 in demo_gradio.py. - Expanded bucket_tools.py with additional resolution options for better image handling.
…justments - Modified total latent sections calculation to use a frame rate of 24 instead of 30. - Updated video length description and output file saving function to align with the new frame rate.
- Added `--resolution_bucket` and `--fp32` arguments for customizable image processing and model precision. - Updated memory management for MPS devices to use recommended maximum memory. - Adjusted GPU memory preservation slider visibility based on high VRAM mode.
- Renamed `--resolution_bucket` argument to `--resolution` for clarity in demo_gradio.py. - Updated image processing logic to utilize the new resolution argument. - Simplified bucket_options in bucket_tools.py by removing resolution-specific keys, allowing for more flexible resolution handling.
…macOS - Renamed installation section for NVIDIA GPUs to improve clarity. - Added detailed installation steps for macOS, including Python 3.10 installation via Homebrew. - Included new arguments for starting FramePack on macOS, enhancing user guidance for configuration options. - Updated resolution handling information to reflect changes in default settings and recommendations for M1/M2 processors.
|
As suggested by lllyasviel#170 (comment), this works on my Mac with a fair speed on rendering. I run it by pointing to a local pytorch folder with pytorch/pytorch#151742 and pytorch/pytorch#151760 applied so that full MPS could be working. Below is the full log of the generation of one video. You can see that the the cost is less than 20 seconds / frame. And the output is good. 250420_224623_192_5524_28.mp4Just for your reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.