update example to use role label instead of name - #101
update example to use role label instead of name#101Jeff McCollum (jeffmccollum) wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49807d61b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
|
|
||
| For Standard mode clusters, create node pools with local SSDs, then deploy: | ||
|
|
||
| Use the stable `braintrust/node-pool` role label in each node selector. Terraform node pool replacements can use generated GKE pool names. |
There was a problem hiding this comment.
For manually created GKE Standard pools or clusters produced by a Terraform module version predating the referenced module change, no node has the custom braintrust/node-pool label—GKE only supplies the former cloud.google.com/gke-nodepool label automatically. The new selectors therefore leave the API and every Brainstore pod Pending, while this section only tells users to create pools and configure selectors. Document the compatible Terraform module version and how to label manually created pools before directing users to these selectors.
Useful? React with 👍 / 👎.
|
Codex (@codex) review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback". |
1 participant
Update gke standard example based of the changes to our GCP TF Module. Should be merged after braintrustdata/terraform-google-braintrust-data-plane#27