fix unit tests - #102
Merged
Merged
Conversation
Andrew Kent (realark)
force-pushed
the
ark/vcr-improvements
branch
2 times, most recently
from
May 12, 2026 22:42
25125b5 to
2225468
Compare
Andrew Kent (realark)
force-pushed
the
ark/vcr-improvements
branch
from
May 13, 2026 00:15
2225468 to
9b807de
Compare
Andrew Kent (realark)
force-pushed
the
ark/vcr-improvements
branch
2 times, most recently
from
May 13, 2026 01:12
746a964 to
468c921
Compare
- bypass recording for otel and s3 - make vcr cassette names deterministic - create braintrust resources on demand in unit tests
Andrew Kent (realark)
force-pushed
the
ark/vcr-improvements
branch
from
May 13, 2026 01:20
468c921 to
28b0aaa
Compare
| } | ||
| var maxVersion = fetchMaxVersion(); | ||
| if (null == maxVersion) { | ||
| return EMPTY_CURSOR; |
Collaborator
Author
There was a problem hiding this comment.
only non-test change. supports empty remote datasets. caught by the test harness
|
|
||
| /** | ||
| * NOTE: playground UI has been updated and breaks the SDK contract. will have to investigate and | ||
| * fixe before this test can be re-enabled |
Collaborator
Author
There was a problem hiding this comment.
seems to be a real issue, but I don't think it's worth blocking on this
Andrew Kent (realark)
marked this pull request as ready for review
May 13, 2026 01:26
Abhijeet Prasad (AbhiPrasad)
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.