fix(python): honor ValidJSON schemas across scorer call paths - #221
Open
JianYan (JianYan11) wants to merge 1 commit into
Open
JianYan (JianYan11) wants to merge 1 commit into
JianYan (JianYan11) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Python
ValidJSONschema handling across constructor, keyword, positional, and partial scorer calls.Two model-free repros on current main:
The constructor saves
self.schemabut validation never reads it. Separately,Scorer.eval()forwardsexpectedpositionally, which collides with theschemaparameter inValidJSON._run_eval_sync(). The same collision affects async partial scorers.Changes
expectedargument slot, preserving the existing second-positional-argument schema convention as a fallback.{},True, andFalse; do not mutate the configured schema.This is Python-specific argument plumbing. The TypeScript implementation already receives its schema in the scorer argument object and is unchanged. No scoring algorithm, dependency, or default validation policy changes.
Validation
PYTHONPATH=py uv run --no-project --python 3.13 \ --with polyleven --with chevron --with pyyaml --with jsonschema \ --with pytest --with pytest-asyncio --with respx -- \ python -m pytest py/autoevals/test_json.py py/autoevals/test_values.py \ -k 'not test_list_contains' -qgit diff --check.test_list_containswas excluded after an initial run showed missing optional NumPy/SciPy dependencies. No live-model tests or full suite were run.AI assistance: implemented and tested with OpenAI Codex.