Fix red main typecheck: import PresenceRouter in presence-scenario.test#153
Merged
Conversation
…echeck was red `presence-scenario.test.ts` (0.4.2 presence tail, bb17615) casts a mock through `PresenceRouter` but never imported it, so `bun run typecheck` failed on main (`TS2304: Cannot find name 'PresenceRouter'`) — blocking the typecheck gate for every open PR. Add the missing type-only import; typecheck:packages green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is typecheck-red
presence-scenario.test.ts(added in bb17615, the 0.4.2 presence tail) casts a mock throughPresenceRouter:…but never imported the type, so
bun run typecheckfails onmain:verifyrunsbun run typecheck, so this blocks the typecheck gate for every open PR. (The 0.4.2 build was unaffected — it's test-only, and the workspacetsc --noEmitisn't the packaging path.)Fix
Add the missing type-only import (
PresenceRouteris used purely as a cast target).typecheck:packages→ exit 0; the test's 3 cases still pass.🤖 Generated with Claude Code