Improve localization: ratio-based top_k, BF16 fix, and rename localize_fed10#402
Open
BKHMSI wants to merge 5 commits into
Open
Improve localization: ratio-based top_k, BF16 fix, and rename localize_fed10#402BKHMSI wants to merge 5 commits into
BKHMSI wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
top_k:localize_fedorenko2010now accepts a float in (0, 1) as a fraction of total units (e.g.0.1= top 10%), in addition to absolute integers.float32before calling.numpy()in both_tensor_to_numpyandextract_representations, fixing a crash when running BF16 models.localize_fed10→localize_fedorenko2010: More descriptive and consistent name; updated all call sites.score_localization.pyis now a reusable function that auto-readsnum_layersandhidden_sizefrom the model config; updated default model toQwen/Qwen3-4B.Test plan
Qwen/Qwen3-4B) and confirm no dtype errorstop_k=0.1selects 10% of units andtop_k=4096still works as an absolute countmodel_id_path(slash-replaced) save path