Rework cxxpiper module - #1108
Merged
Merged
Conversation
Migrate now deprecated/archived piper-phonemize[1] based cxxpiper implementation to libpiper[2] which was recently added to the upstream piper repository. Because we are now using the upstream libpiper C library directly, I figured we should probably also remove the cxx prefix from the module name. Changes made: - Removed conf options that new libpiper no longer support - Added peak normalization for parity with Python CLI - Simplified voice handling and configuration [1]: https://github.com/rhasspy/piper-phonemize [2]: https://github.com/OHF-Voice/piper1-gpl/tree/main/libpiper
Collaborator
|
I added CI on top of this to be able to check the build, and the code indeed looks fine and much more maintainable :) |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Code changes assisted by LLM. I have very limited experience with C++ and autotools. I've done my best to review the code and verify that it at least works on my machine. Apologies for any obvious mistakes that I didn't catch.
Migrate now deprecated/archived piper-phonemize1 based cxxpiper implementation to libpiper2 which was recently added to the upstream piper repository. (as requested in #1092 (comment))
Because we are now using the upstream libpiper C library directly, I figured we should probably also remove the cxx prefix from the module name. (on top that, also many breaking changes and redesigns)
Changes made: