[CLOSED] [ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap)

[core-ai-bot]

Issue by WebsiteDeveloper
Sunday May 26, 2013 at 11:10 GMT
Originally opened as adobe/brackets#3996

---

@gruehle finally rebased correctly.
This supersedes #3672.

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3996/commits

[core-ai-bot]

Comment by TuckerWhitehouse
Sunday May 26, 2013 at 15:31 GMT

---

@WebsiteDeveloper modal windows seem to be broken. If I try to open Brackets > About or File > Extension Manager, I get the backdrop, but no modal window... and then brackets goes into a sort of broken state where none of the menu commands word, and I have to force close it. No errors in the dev console.

Mac OS X 10.8.3

[core-ai-bot]

Comment by WebsiteDeveloper
Sunday May 26, 2013 at 15:39 GMT

---

i already saw that myself, it seems that this is related to the dialog animations.
will put up a fix.

[core-ai-bot]

Comment by WebsiteDeveloper
Sunday May 26, 2013 at 16:44 GMT

---

@TuckerWhitehouse pushed a fix.
I would appreciate it if you would test the branch a bit more and notify me about anything you notice.

[core-ai-bot]

Comment by TuckerWhitehouse
Sunday May 26, 2013 at 18:28 GMT

---

@WebsiteDeveloper looks good!
Using it to test right now and everything seems to be working without issue. I'll let you know if I find anything.

[core-ai-bot]

Comment by gruehle
Tuesday May 28, 2013 at 20:50 GMT

---

Found another one that needs updating: alert-message should be alert. This is used in the find bar, project settings dialog, and a couple extension dialogs.

[core-ai-bot]

Comment by gruehle
Tuesday May 28, 2013 at 20:56 GMT

---

And one more: Twipsy. Live Development shows a twipsy when the connection has been severed. Twipsy has been renamed Tooltip, so the live dev code needs to be updated, and src/widgets/bootstrap-twipsy-mod.js should be removed.

[core-ai-bot]

Comment by njx
Tuesday May 28, 2013 at 21:00 GMT

---

@DennisKehrig made a number of modifications to Twipsy to deal with our use case. Those would need to be ported to the new version.

[core-ai-bot]

Comment by dangoor
Thursday May 30, 2013 at 19:19 GMT

---

@WebsiteDeveloper Thanks for all of the work on getting LESS and Bootstrap updated!

@TuckerWhitehouse and I have been working on the jQuery 2.0 update. We really want to get all of these upgraded packages on master as early as we can to get the most testing on it that we can. To that end, I've put up a branch that has everything integrated (including this pull request):

https://github.com/adobe/brackets/tree/jQueryLESSBootstrap

Brackets doesn't boot on that branch because of Twipsy (fails on $.browser, which is gone).

@WebsiteDeveloper how are your latest fixes coming? I can help out if there's something you haven't gotten to yet, and Glenn will be back around tomorrow. Ideally, we'd merge jQueryLESSBootstrap to master tomorrow.

Thanks again! Getting all of these upgrades in this sprint will be great.

[core-ai-bot]

Comment by WebsiteDeveloper
Thursday May 30, 2013 at 19:47 GMT

---

@dangoor all fixes except the replacement of the twipsy plugin should be done.

[core-ai-bot]

Comment by WebsiteDeveloper
Thursday May 30, 2013 at 19:51 GMT

---

Is there a good way too test the appearance and the behavior of the twipsy?
So i can try to replace it with the tooltip.

[core-ai-bot]

Comment by gruehle
Thursday May 30, 2013 at 20:50 GMT

---

@WebsiteDeveloper - the easiest way to see the twipsy is to start live development and then show dev tools on the opened page. You will see a twipsy pointing to the live development lightning bolt.

For reference, #2178 is the pull request where twipsy was added (and modified).

[core-ai-bot]

Comment by WebsiteDeveloper
Friday May 31, 2013 at 15:09 GMT

---

@dangoor i would appreciate a bit help with the tooltip, because i currently don't have the time to digg into it.

[core-ai-bot]

Comment by dangoor
Friday May 31, 2013 at 16:34 GMT

---

@WebsiteDeveloper I've taken a bit of a look. Unfortunately, our changes to twipsy don't cleanly apply to the tooltip. If@gruehle doesn't get to it today, I can take a look Monday morning.

Making the tooltip work properly appears to be the big thing keeping the jQueryLESSBootstrap branch from working reasonably well (possibly well enough to merge for testing to begin)

[core-ai-bot]

Comment by njx
Friday May 31, 2013 at 16:58 GMT

---

@DennisKehrig made the original twipsy mods - Dennis, would you have any time to help out with migrating it to Bootstrap 2?

[core-ai-bot]

Comment by DennisKehrig
Friday May 31, 2013 at 17:01 GMT

---

@njx Not for at least another week, sadly!