Repository navigation
chore(shared): drop the dead OHOS source set and HarmonyOS mentions in code - #3377
Merged
stamp-build[bot] merged 1 commit intoOct 21, 2026
Merged
Conversation
…n code HarmonyOS was removed in #3181; this clears what was left in compose/**. - Delete compose/shared/src/ohosArm64Main (no target compiles it; no Gradle config references it). - Replace the "Harmony smoke" / "generated OHOS paths" labels on internal smoke and icon-gallery pages with platform-neutral text. - i18n allowlist: drop five stale entries ("Floating Dock" and four literals whose pages moved to visualFixtures) and re-review the two renamed labels, so the scanner passes on the whole repo again. - Reword OHOS/HarmonyOS/ArkTS comments to Android/iOS or drop them. Comments only; no behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stamp-build
Bot
force-pushed
the
agent/codex-android-devops/code-drop-harmonyos
branch
from
October 21, 2026 05:09
af00dc3 to
c14fb4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the third HarmonyOS cleanup PR, after #3371 (docs) and #3373 (CI/scripts). It removes the last HarmonyOS/OHOS parts from
compose/**. It is done on artin's instruction ("鸿蒙部分都删了": remove all the HarmonyOS parts). No behaviour change: the only non-comment edits are three strings on internal smoke/diagnostic screens.Dead source set
compose/shared/src/ohosArm64Main/(onlyRaftStoreConfinement.ohos.kt). No Gradle file, buildSrc orgradle.propertiesreferencesohosArm64*or the source set; the remaining actuals are in:coreandroidMain/iosMain.HarmonyOS literals (internal smoke/diagnostic pages)
SettingsHomePage.kt: "Harmony smoke preview" becomes "Shared tab bar smoke preview", and thesettingsTabBarSmokePayloadsubtitle "Harmony smoke" becomes "Tab bar smoke".RaftLucideIconGalleryPage.kt: "${names.size} icons · generated OHOS paths" becomes "… · generated vector paths".i18n scanner now passes on the whole repo
scripts/i18n_code_literal_allowlist.json: removed five stale entries. One was "Floating Dock", whose literal no longer exists. The other four ("MENU ACTION", "MODAL ACTION", "UNDERLAY HIT", "CURSOR MOVED") belong to pages that moved tosrc/visualFixtures, which the scanner excludes. Added reviewed exceptions for the two renamed smoke/gallery literals.python3 scripts/i18n_code_literal_scan.pynow exits 0 (805 files, 1587 advisory findings, 29 reviewed exceptions). Before, it raised on stale entries.Comments
compose/shared,compose/core,compose/androidApp,compose/iosApp(ObjC/Swift) andcompose/gradle.properties. They drop OHOS/HarmonyOS/ArkTS from platform lists, or reword them to Android/iOS where the comment still describes current cross-platform behaviour. Examples: the shared 50MB feedback cap, native string-lookup and template resolution, and coroutines-test-free commonTest.Intentionally left (not comments, or still accurate)
commonTest:"OHOS Phone"/"HarmonyOS"labels, theraft-ohosrelease-notes slug, theos in setOf("android","ios","ohos")assertion,ohos*test method names and fixture ids, and the.hapfile-name fixture. Changing these is a test-code edit, not a comment cleanup.RaftModuleCompat.ExecuteMode.OHOS_NATIVE(4): an enum/wire value.ThreadMessageRowVisualFixtures.kt:1367. Changing it would change goldens.AndroidPushRegistration.kt/RaftPlayServicesAvailability.ktmention "HarmonyOS's Android compatibility layer". That is about Huawei devices running the Android app, which is still relevant.THIRD_PARTY_NOTICES.md, to be handled in a separate notices refresh.Checks
./gradlew :shared:compileDebugKotlinAndroid :core:compileAndroidMain(through the shared build-slot wrapper): BUILD SUCCESSFULpython3 scripts/i18n_code_literal_scan.py(json and markdown): exit 0scripts/qa/test_i18n_code_literal_scan.py: 18 OKscripts/ci/check_source_constraints.py(--self-testand real run),check_string_edge_spaces.py,verify_no_production_visual_pages.py,visual_fixture_split_census.py,test_kuikly_raft_consumer_contract.py,scripts/check_slock_source_path_contract.sh: all passcompose/**is limited to the three literals above (checked withgit diff -U0, filtering comment lines).🤖 Generated with Claude Code