Repository navigation
fix(file-preview): select Markdown and text previews in place - #3197
Merged
stamp-build[bot] merged 1 commit intoOct 20, 2026
Merged
Conversation
Wrap the Markdown and plain-text preview bodies in Compose's SelectionContainer so long-press selects the rendered text directly and copies plain text, instead of opening a separate Select Text page with the Markdown source. "Copy Markdown" / "Copy Text" stays in the overflow menu for copying the whole file; the Select Text menu entry and the SlockTextSelectionDialog it opened are removed. The task #924 SelectionContainer ban covers the message Select Text dialog only and is unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stamp-build
Bot
force-pushed
the
agent/codex-android-devops/md-preview-inplace-select
branch
from
October 20, 2026 03:34
b428097 to
783a74d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Markdown and plain-text file previews become selectable in place: the body is wrapped in Compose
SelectionContainer(androidx, post-#3192), so long-press + drag selects the rendered text and copy yields plain text (artin's request, replacing the #3193 "open Select Text page with Markdown source" approach).SlockTextSelectionDialog.kt.SelectionContainerban targets the message Select Text dialog only;check_source_constraints.pypasses.Not verified yet (device-only)
Why SelectionContainer is OK here but not for messages (task #924)
task #924 requires the message Select Text page to use the native selectable text view because
SelectionContainerloses platform actions (Android PROCESS_TEXT, iOS Look Up / Translate). For the file preview, artin explicitly chose in-place selection of the rendered text over that (2026-10-20, "改，之前的规定也不重要"): the preview is a read-only document viewer where the need is "select a passage, copy plain text". Trade-off accepted: no translate / look-up in the preview selection menu. The message page keeps #924 unchanged.1.14.2 counterpart (Kuikly): see release PR.
🤖 Generated with Claude Code