-
Notifications
You must be signed in to change notification settings - Fork 44
refactor: make xorq an optional (extra) dependency #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deepyaman
wants to merge
18
commits into
boringdata:main
Choose a base branch
from
deepyaman:refactor/optional-xorq
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
83b2bb7
refactor: make xorq an optional dependency (extra)
deepyaman 76cb4dc
fix: tighten any post-optionalization housekeeping
deepyaman 7e88f23
fix: align test-no-xorq CI job with the main test job
deepyaman 9a61507
fix: replace xo.window with ibis.window in test_chart.py
deepyaman e3c120d
refactor: restructure dev extra, drop self-referential bundle
deepyaman b6ce85f
fix: update CI install to skip xorq and examples extras
deepyaman b88fd7c
fix: skip xorq-dependent tests when xorq is not installed
deepyaman 861ad2f
fix: replace xorq.vendor.ibis with plain ibis
deepyaman e12ae33
fix: update dependency group tests for new dev structure
deepyaman 1d64bdb
fix: raise on undefined env vars in plain-ibis profiles
deepyaman 4bbc547
fix: no-xorq parity for join rebinding and dimension-only shortcut
deepyaman 5d97122
test: use xibis shim idiom for flavor-sensitive tests and demo
deepyaman 05e7b4a
test: standardize xorq-only skips on importorskip; clarify pushdown x…
deepyaman dd2eb03
ci: parametrize test job over xorq extras; split build into its own job
deepyaman a2b367d
chore: minimize lockfile churn; document test-core extra
deepyaman d74c944
refactor: drop duplicated walk_nodes fallback; trim rebinding comments
deepyaman 8d1fbc6
ci: self-skip integration dir without xorq via collect_ignore_glob
deepyaman b649f34
docs: hyphenate xorq-vendored ibis; clarify walk_nodes stub rationale
deepyaman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? Was something like this there before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes — it predates this refactor:
main'stest-no-xorqjob had aVerify import works without xorqstep. It's a cheap smoke test that separates "the package does not import" from "a test failed" — especially meaningful for the no-xorq leg, whose whole purpose is proving BSL imports cleanly without xorq before the slower suite runs. The matrix just kept it. Happy to gate it tono-xorqonly if you'd rather not have the (redundant) run on thefullleg.