fix: guard size_t template specializations for Win64#183
Open
thatdudegrantt wants to merge 1 commit into
Open
Conversation
On 64-bit Windows, size_t and uint64_t are the same underlying type, causing duplicate explicit template specialization errors when building the MATLAB wrapper. Guard both wrap<size_t> and unwrap<size_t> with #if !defined(_WIN64) || defined(__CUDACC__). this is because gtsam/wrap inherits from the wrap repository. Successfully locally tested the change in gtsam/wrap/matlab.h, and then migrating to truly make the change. I will be more careful about this in the future.
There was a problem hiding this comment.
Pull request overview
This PR addresses a Win64 build failure in the MATLAB wrapper caused by duplicate explicit template specializations when size_t and uint64_t resolve to the same underlying type.
Changes:
- Conditionally compiles the
wrap<size_t>specialization to avoid conflicts on 64-bit Windows. - Conditionally compiles the
unwrap<size_t>specialization to avoid conflicts on 64-bit Windows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 64-bit Windows, size_t and uint64_t are the same underlying type, causing duplicate explicit template specialization errors when building the MATLAB wrapper. Guard both wrap<size_t> and unwrap<size_t> with #if !defined(_WIN64) || defined(CUDACC).
this is because gtsam/wrap inherits from the wrap repository as a snapshot copy, syncing using update_wrap.sh. (which wouldve overwritten a solution in the gtsam/wrap/matlab.h.
Successfully locally tested the change in gtsam/wrap/matlab.h, and then migrating to truly make the change. I will be more careful about this in the future.
fixes borglab/gtsam#2505