fix(terms): erase generated terms via the correct flag option key - #228
Merged
Merged
Conversation
Term generation flags terms in the option fakerpress.module_flag.terms (plural, via get_slug()), but fetch()/delete() read and cleared the singular fakerpress.module_flag.term, so 'Erase faked data' always collected an empty set and never removed generated categories/tags. Align fetch()/delete() to the plural key with regression coverage for the flag -> fetch -> delete cycle. Fixes #219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219
Problem
The "Erase faked data" tool did not delete generated Categories (or any terms); all other faked data was removed correctly.
Root cause
Term generation flags terms in the option
fakerpress.module_flag.terms(plural, viaget_slug()):But
fetch()anddelete()hard-coded the singular key:So the erase routine always received an empty set and never called
wp_delete_term().Fix
Align
fetch()/delete()to the sameget_slug()-based key that generation writes. Terms generated before the fix were stored under the plural key, so they are now correctly picked up.Tests
TermEraseTestcovers the flag → fetch → delete cycle:fetch()returns the flagged terms, anddelete()removes both a category and a tag and clears the flag option.Milestone: 0.9.2