Test composefs#81
Open
alicefr wants to merge 6 commits into
Open
Conversation
Collaborator
Author
|
The REUSE test will fail until #79 is merged |
Collaborator
Author
|
/cc @Johan-Liebert1 |
Use the Ginkgo Label("composefs") decorator so that the cluster
creation test can be selected with --label-filter. Read BINK_NODE_IMAGE
env var to allow overriding the default node image at runtime.
Assisted-by: Claude Opus 4.6 (1M context)
Signed-off-by: Alice Frosi <afrosi@redhat.com>
Provide a dedicated target to run only composefs-labeled tests using ginkgo --label-filter, mirroring the existing test targets. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Run the composefs-labeled subset of integration tests against the composefs node image to validate the composefs backend on every push and PR. Sets BINK_NODE_IMAGE to the composefs disk image so the test uses it instead of the default. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Composefs-based images do not have /etc/fstab, causing cloud-init runcmd to fail and report error status. Traditional bootc images use a regular filesystem where /etc/fstab lists mount points. Composefs-based images use a content-addressed, read-only erofs filesystem overlay where root mounting is handled by ostree deployment metadata and the initramfs boot logic, not by /etc/fstab. Since there are no traditional block-device mounts to describe, the file is simply absent. Guard the sed command with a file-existence check so cloud-init succeeds on both composefs and non-composefs images. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
The origin file path and format differ between ostree and composefs: - ostree: /ostree/deploy/default/deploy/<checksum>.<serial>.origin - composefs: /sysroot/state/deploy/<verity>/<verity>.origin - composefs uses spaces around '=' in key-value pairs Use find to locate the origin file in both paths, and fix the sed pattern to match both formats. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Previously WaitForCloudInit retried forever when cloud-init reported "error", but that is a terminal state — the status will never change to "done". Accept it with a warning instead of blocking for the full timeout. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Johan-Liebert1
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add infrastructure to tests composefs