Add most tests to CMake build and fix some test dependencies - #158
Open
Flamefire wants to merge 5 commits into
Open
Add most tests to CMake build and fix some test dependencies#158Flamefire wants to merge 5 commits into
Flamefire wants to merge 5 commits into
Conversation
The dependency on Boost.Random is already set for all targets
Build is usually already done as shared and static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although BoostTestJamfile is used many tests are not included in the CMake build because they are not of the form
run source.cpp ;but specify extra dependenciesI replaced that call by a small Jamfile parser that knows about the dependencies.
This surfaced a few dependency issues in the Jamefile:
test_random_devicewas always compiled as static and shared, also compiling all dependencies twice. CI uses./b2 link=static,sharedexplicitly which I'd say is a cleaner way to test than basically forcing thisAlso a mini-change to avoid the deprecation warning from Boost.Bind