Narrow the condition for the parent assignment optimisation to union …#1478
Merged
tinko92 merged 1 commit intoJun 29, 2026
Merged
Conversation
…only, fixing case_bitset_3.
barendgehrels
approved these changes
Jun 28, 2026
barendgehrels
left a comment
barendgehrels
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks completely right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes case_bitset_3 which fails for intersection due to the optimisation for one outer ring, which seems only safe for union (that seems to be consistent with the comment). The local is_difference variable was removed because it is now unused and no new variable was created because this condition is checked only on one line and is readable. The test case was enabled.