Skip to content

Added asan and ubsan to CI#713

Merged
kris-jusiak merged 1 commit into
boost-ext:masterfrom
vasdal:feature/add-sanitizer
Jun 11, 2026
Merged

Added asan and ubsan to CI#713
kris-jusiak merged 1 commit into
boost-ext:masterfrom
vasdal:feature/add-sanitizer

Conversation

@vasdal

@vasdal vasdal commented Jun 10, 2026

Copy link
Copy Markdown

Problem:
Discovered that asan,ub triggers on gcc
Fails:

Solution:

Issue: #

Reviewers:
@kris-jusiak
@PavelGuzenfeld

@vasdal vasdal force-pushed the feature/add-sanitizer branch from efa41d2 to e63d78c Compare June 10, 2026 11:30
@PavelGuzenfeld

PavelGuzenfeld commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@vasdal ,
Thanks for the PR. I'll reproduce it locally and get back to you.

@PavelGuzenfeld

Copy link
Copy Markdown
Contributor

Reproduced on GCC 13.3.0 (what ubuntu-latest and the Godbolt g133 link use). The issue reproduces.

  • No sanitizer (-O0 and -O2): fine.
  • asan+ubsan -O0 (your Debug job): UBSan OOB index + real ASan SEGV at sml.hpp:2312.
  • asan+ubsan -O2: fine.

I printed the actual event.id and it's 1 — a valid index into a 2-entry table. So the SML logic is fine; GCC 13.3 just emits a garbage index for the folded (this->*dispatch_table[event.id])(...) under sanitizers at -O0. 13.4 and 14.x don't repro. Your hoist-to-a-local fix is clean — full ft suite 39/39 under asan+ubsan.

The existing test/ft/actions_process.cpp already hits this path, so it segfaults on master under the new job and passes with the fix — no new test needed, it just slipped through because there was no sanitizer job before.

Two small comment nits (it lives in the header): it says "GCC-11" but everything I saw fail is GCC 13.x, and "false positive" is really a miscompilation/crash. Otherwise LGTM.

@vasdal vasdal force-pushed the feature/add-sanitizer branch from e63d78c to 8b427ee Compare June 11, 2026 06:20
@vasdal

vasdal commented Jun 11, 2026

Copy link
Copy Markdown
Author

Thanks @PavelGuzenfeld, fixed the comment now.
Possible to make g++ asan+ubsan required in the future?

@kris-jusiak kris-jusiak merged commit 68fa535 into boost-ext:master Jun 11, 2026
6 checks passed
@kris-jusiak

Copy link
Copy Markdown
Collaborator

Thank you @vasdal and @PavelGuzenfeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants