Skip to content

Ignore testdata in broad scanner walks#219

Merged
bomly-guy merged 1 commit into
mainfrom
codex/ignore-testdata-scorecard
Jun 30, 2026
Merged

Ignore testdata in broad scanner walks#219
bomly-guy merged 1 commit into
mainfrom
codex/ignore-testdata-scorecard

Conversation

@bomly-guy

Copy link
Copy Markdown
Collaborator

Summary

  • add a gitignore pattern for committed testdata fixture directories so broad repository scanners that honor gitignore skip fixture lockfiles and SBOMs
  • keep existing tracked fixtures editable while requiring git add -f only for brand-new ignored fixture files

Why

OpenSSF Scorecard runs its Vulnerabilities check through osv-scanner over the repository checkout. The scanner was treating dependency detector fixtures under testdata as live project manifests, which produced noisy Code Scanning vulnerability alerts unrelated to the CLI product dependency set.

Validation

  • git check-ignore --no-index -v internal/detectors/node/testdata/lockfiles/pnpm-v5/pnpm-lock.yaml internal/detectors/ruby/testdata/project/Gemfile.lock test/smoke/testdata/sboms/js.spdx.json
  • temp normal git clone with patched .gitignore: osv-scanner@v1.9.2 scan --skip-git -r reports 0 non-Go-stdlib vulnerabilities
  • git diff --check
  • make test

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@bomly-guy, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 15863c91-32bb-46ba-8ed5-2c6816159e6c

📥 Commits

Reviewing files that changed from the base of the PR and between 1d1112e and 57a35d1.

📒 Files selected for processing (1)
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ignore-testdata-scorecard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bomly-guy bomly-guy marked this pull request as ready for review June 30, 2026 06:47
@bomly-guy bomly-guy merged commit 9e7ce2e into main Jun 30, 2026
10 of 11 checks passed
@bomly-guy bomly-guy deleted the codex/ignore-testdata-scorecard branch June 30, 2026 06:47
@github-actions

Copy link
Copy Markdown
Contributor

Bomly Diff Summary

Compared d4d282c6f55053315789b451e468f8f5ee9252ba to 57a35d1d6d7b258c509455d2bb9bc3de6c84d573.

Overview

Status Manifests Dependencies Findings Duration
✅ Pass +0 / ~0 / -0 +0 / ~0 / -0 0 introduced / 0 persisted / 0 resolved 1m 0s

Dependency Changes

✅ No dependency changes.

Vulnerabilities

✅ No vulnerability changes.

License Changes

✅ No license changes.

Project Posture

✅ No project posture changes (--matchers +scorecard was not selected).

Policy Findings

✅ No policy differences were identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant