feat(prompts): support maxItems in groupMultiselect#528
Merged
43081j merged 2 commits intobombshell-dev:mainfrom May 8, 2026
Merged
feat(prompts): support maxItems in groupMultiselect#52843081j merged 2 commits intobombshell-dev:mainfrom
43081j merged 2 commits intobombshell-dev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 70ae450 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
43081j
approved these changes
May 8, 2026
Collaborator
|
i will fix the problem with wrapping. it isn't only in limitOptions, its mostly in group multi-select itself. gnarly stuff but i'll sort it in a follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If
groupMultiselecthave many items, it interferes with the rendering instead of scrolling itself. This PR implements the scrolling behaviour similar tomultiselectusinglimitOptions.Also, due to refactoring for
limitOptions, ifwithGuide: false, the multiselect will no longer have an indent, which matches the styling ofmultiselectand other prompts.Closes #526
Demo:
Screen.Recording.2026-05-07.at.8.09.23.PM.mov
Additional notes
multiselectlimitOptionsdoes not seem to handle new lines within options well, which could happen whengroupPadding > 0is set (which prepends new lines before group options). It assumes every option takes up one line when calculating the truncation. I did not fix this in the PR as I feel it's a separate issue.Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure