Replace busboy with built-in multipart parser for supply-chain safety - #22
Open
singularitycurse26-svg wants to merge 1 commit into
Open
Replace busboy with built-in multipart parser for supply-chain safety#22singularitycurse26-svg wants to merge 1 commit into
singularitycurse26-svg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Problem
The busboy library is described as very leet code that is hard to inspect. The issue asks for a review or rewrite to guarantee side-effect safety.
Solution
Replaced the busboy dependency with a simple, auditable
parseMultipartFormDatafunction implemented using only Node.js built-in Buffer APIs.Changes
server/ServerSession.ts:import busboy from "busboy"throw new CommunicationError("multipart/form-data file uploads not yet implemented")with actual working multipart parsing using the newparseMultipartFormData()functionparseMultipartFormData()— a self-contained parser that:Buffer.indexOf,Buffer.slice, andBuffer.toString(no external deps)server/package.json:busboyfrom dependencies@types/busboyfrom devDependenciesSecurity Benefits
/claim #6