Skip to content

everyauth contribution and fixes#178

Open
orkaplan wants to merge 3 commits into
bnoguchi:masterfrom
orkaplan:master
Open

everyauth contribution and fixes#178
orkaplan wants to merge 3 commits into
bnoguchi:masterfrom
orkaplan:master

Conversation

@orkaplan

Copy link
Copy Markdown

Hi,
I wanted to contribute to the everyauth project, this requests includes the next features:

  1. Windows Live OAuth implementation
  2. fix for issue OAuthException: redirect_uri isn't an absolute URI. #153 (the solution gilad61 suggested)
  3. pass to the moduleErrback seq.values, to allow sending response to the user in case of errors during the authentication process instead of throwing an error. in the future I consider to add the next() method of connect to the seq.values, in order to follow connect error handlers guide lines by calling next(err).

ork.

/cc @gilad61 @mojodna

@bnoguchi

Copy link
Copy Markdown
Owner

Thanks for the contribution. Could you rename the module and related files to everyauth.windowsLive and windows_live respectively?

@orkaplan

Copy link
Copy Markdown
Author

fixed, will be glad for comments

@ForbesLindesay

Copy link
Copy Markdown

+1

@JonnyBGod

Copy link
Copy Markdown

+1

1 similar comment
@jrundquist

Copy link
Copy Markdown

+1

@hmeerlo

hmeerlo commented Dec 19, 2012

Copy link
Copy Markdown

+1 Please integrate at least the oauth2 fix. Everyauth doesn't work on loadbalanced environments now.

@thomas-louvigne

Copy link
Copy Markdown

+1

@loganfuller

Copy link
Copy Markdown

+1. This pull fixes an issue for Oikoi.

@hmalphettes

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants