Remove unused DataElement placeholder (#9, #61)#109
Merged
Conversation
`src/harmonization_framework/element.py` defined `DataElement` and `DEType` as a placeholder for a domain model that was never finished or adopted. A repo-wide search confirms nothing imports either symbol — rules use plain strings for source/target column names, primitives work on values directly, and the API surface has no DataElement-shaped endpoints. The competing ORM-side DataElement that motivated the naming-collision concern in #61 was already removed in 879f49e (Jan 2026) when the database layer was retired. So both the placeholder and the collision it was designed to coexist with are gone. Closes #9, #61. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/harmonization_framework/element.pydefinedDataElementandDETypeas placeholders for a domain model that was never finished or adopted. A repo-wide search confirms nothing imports either symbol:Only self-references. Rules use plain strings for source/target column names, primitives work on values directly, and the API has no DataElement-shaped endpoints.
The competing ORM-side
DataElementthat motivated the naming-collision concern in #61 was already removed in 879f49e (Jan 2026) when the database layer was retired — so both the placeholder and the collision it was designed to coexist with are obsolete. The bug in #9 (no__init__, broken__hash__) only matters if the class were used, which it isn't.Rather than finish an unused abstraction speculatively, delete it. A real
DataElementmodel can be designed when there's a concrete consumer (e.g. ontology integration, RADx Data Dictionary alignment).Closes #9, #61.
Test plan
🤖 Generated with Claude Code`