fix(apple): suppress legacy SCNetworkReachabilityGetFlags warning#4
Open
bmehta001 wants to merge 3 commits intobhamehta/issue-1418-mainfrom
Open
fix(apple): suppress legacy SCNetworkReachabilityGetFlags warning#4bmehta001 wants to merge 3 commits intobhamehta/issue-1418-mainfrom
bmehta001 wants to merge 3 commits intobhamehta/issue-1418-mainfrom
Conversation
bmehta001
force-pushed
the
bhamehta/issue-1425-off-1418
branch
2 times, most recently
from
7b3c0e0 to
8c7b8a0
Compare
bmehta001
force-pushed
the
bhamehta/issue-1425-off-1418
branch
from
8c7b8a0 to
8a05179
Compare
* Modernize CI workflows and fix iOS simulator selection - Update Actions to latest versions (checkout@v4, setup-java@v5, etc.) - Add concurrency groups scoped to PR events only (push builds on main always run to completion) - Add 30-minute timeout to iOS CI to prevent deadlock hangs - Fix iOS simulator UUID resolution for unambiguous destination - Fix Android SDK path detection in CodeQL workflow - Document python3 requirement for iOS tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix compiler flags and scope -Wno-reorder - Split GCC/Clang warning flags (Clang-only flags were breaking GCC) - Add -fno-finite-math-only to restore IEEE 754 compliance needed by sqlite3 when -ffast-math is enabled - Remove global -Wno-reorder, scope to Sanitizer.cpp only (submodule declares members in wrong order) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Improve iOS test script and documentation - Resolve simulator UUID for unambiguous xcodebuild destination - Add python3 dependency documentation - Update iOS getting-started docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix flaky functional tests for iOS simulator CI - Use unique phase2 DB paths instead of sleep to avoid SQLite vnode collisions from deferred sqlite3_close_v2 cleanup - Clean SQLite journal files (-wal, -shm, -journal) in CleanStorage - Fix cross-test config contamination (reset storage settings) - Use sleep(10) instead of yield() in waitForEvents to reduce CPU contention on single-core simulator runners - Increase timeouts for iOS simulator environment - Fix multi-batch upload flakiness with SetTransmitProfile(RealTime) - Use 127.0.0.1 instead of localhost for local test server Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Remove private in6 header includes Remove the dead netinet6/in6.h imports from ODWReachability and its Objective-C unit test so Apple builds no longer fail on the private-header error from main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove dead reachability imports Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore explicit reachability socket headers Add back the canonical sys/socket.h and netinet/in.h includes in ODWReachability.m and ODWReachabilityTests.mm while keeping the other dead imports removed. This avoids relying on transitive Apple headers in the reachability PR review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmehta001
force-pushed
the
bhamehta/issue-1425-off-1418
branch
from
8a05179 to
2efd18f
Compare
Add pragma to suppress SCNetworkReachability deprecation warnings in ODWReachability.m. These APIs (SCNetworkReachabilityCreateWithName, SCNetworkReachabilityCreateWithAddress) were deprecated in iOS 17.4 and trigger -Werror build failures in Xcode 26.4+. A full migration to NWPathMonitor is tracked separately; this unblocks the build. Fixes microsoft#1425 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmehta001
force-pushed
the
bhamehta/issue-1425-off-1418
branch
from
2efd18f to
b4a3fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCNetworkReachabilityGetFlagswarning with a narrow, backwards-compatible fixTesting
xcrun clangcompile against the iPhoneSimulator 26.4 SDK with-Werror -Wdeprecated-declarationsStack
copilot/issue-1418-mainRefs microsoft#1425