-
Notifications
You must be signed in to change notification settings - Fork 2
chore(release): 0.7.4 — deferred-work sweep no longer defers every bundle it finished #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e2a8636
4276c67
4ae716f
e277c34
3b55fa8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,4 +6,4 @@ | |
| spec files, and the per-run directory under .automator/runs/. | ||
| """ | ||
|
|
||
| __version__ = "0.7.3" | ||
| __version__ = "0.7.4" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -702,7 +702,11 @@ def verify_dev_bundle( | |
| review_enabled: bool = True, | ||
| ) -> VerifyOutcome: | ||
| """verify_dev for a deferred-work bundle: bundles have no sprint-status | ||
| entry, but the session must claim exactly the dw ids the bundle owns.""" | ||
| entry. The orchestrator owns the bundle→dw-id binding (``task.dw_ids``, | ||
| marked done by ``SweepEngine._post_dev_state_sync``); the generic | ||
| ``bmad-dev-auto`` primitive never authors dw ids. So the dw_ids cross-check | ||
| is enforced only when the session actually claims them — an empty/absent | ||
| claim is the normal generic path and passes.""" | ||
| rj = result_json or {} | ||
| spec_file = rj.get("spec_file") | ||
| if not spec_file: | ||
|
|
@@ -739,8 +743,8 @@ def verify_dev_bundle( | |
| except GitError as e: | ||
| return VerifyOutcome.escalate(str(e)) | ||
|
|
||
| claimed_ids = {str(i) for i in rj.get("dw_ids", [])} | ||
| if claimed_ids != set(task.dw_ids): | ||
| claimed_ids = {str(i) for i in (rj.get("dw_ids") or [])} | ||
| if claimed_ids and claimed_ids != set(task.dw_ids): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Valid — fixed in 3b55fa8. Our |
||
| return VerifyOutcome.retry( | ||
| f"result.json dw_ids {sorted(claimed_ids)} do not match the bundle's " | ||
| f"{sorted(task.dw_ids)}" | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/automator/adapters/generic.py:331:(spec.env.get("BMAD_AUTO_DW_IDS") or "").split(",")still assumes a string; if a hook sets a truthy non-string (e.g., list/int), this will raise and can incorrectly mark a completed session as stalled.Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining this one, by design.
spec.envis typeddict[str, str]and is consumed as the process environment ({**self.profile.env, **spec.env}at generic.py:118/142), which only accepts string values — a list/int there would fail at session launch, so the session could never reach the Stop event that calls_result_json. The guarded state is unreachable. Andstr()-coercing would be actively wrong: a list["DW-1","DW-2"]stringifies to"['DW-1', 'DW-2']", whichsplit(",")turns into garbage tokens → a spurious dw_ids mismatch, the exact false-defer this PR fixes. A crash on a hard type-contract violation is preferable to silently-wrong behavior; the shippedor ""guard already coversNone, the only idiomatic unset sentinel.