refactor: polish NotePing response handling#245
Merged
zfields merged 2 commits intoJun 4, 2026
Conversation
zfields
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JIsExactStringfor nonce response validationStack note
This branch includes #244 as its first commit so CI can run cleanly while both PRs target
ray/autobaud. After #244 merges, this PR should reduce to then_request.cpolish commit only.Verification
docker run --rm -v /home/ubuntu/.openclaw/workspace/note-c:/note-c -w /note-c ghcr.io/blues/note_c_ci:latest bash -lc 'rm -rf build && cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug && cmake --build build --target NotePing_test -j2 && cd build && valgrind --track-origins=yes --leak-check=full ./test/NotePing_test "Scenario: NotePing"'\n\nValgrind result:ERROR SUMMARY: 0 errors from 0 contexts.\n\n## Architecture docs\n\nConsidered; no update needed because this is an implementation-level cleanup of behavior already introduced by feat: NotePing() allows for testing to see if a notecard is responding sans delays/retry #239.