Repository navigation
fix(conversion): resolve local includes relative to parent definition - #295
Merged
Merged
Conversation
Member
|
Hello, fix tests and this will be merged. |
krmartin100
force-pushed
the
fix/relative-include-paths
branch
from
September 22, 2026 12:35
f649634 to
3bdf64a
Compare
Contributor
Author
|
Hello, fixed the tests and force-pushed the updated commit. |
krmartin100
force-pushed
the
fix/relative-include-paths
branch
from
September 23, 2026 08:31
3bdf64a to
87cd3e4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 86.00% 86.48% +0.48%
==========================================
Files 696 696
Lines 5458 5492 +34
==========================================
+ Hits 4694 4750 +56
+ Misses 764 742 -22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hello @aler9, can we merge this? |
* prevent parsing the same file twice
Member
|
i had to improve the PR to deal with a couple of things:
|
Member
|
other than that, this has been merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix relative paths in nested XML dialect includes
When a dialect includes
sub/child.xmland that file includessibling.xml, the latter must be resolved relative tosub/child.xml,not to the process working directory.