reliability: guard crash paths in DHCP/network teardown#3291
Open
geraldo-netto wants to merge 2 commits into
Open
reliability: guard crash paths in DHCP/network teardown#3291geraldo-netto wants to merge 2 commits into
geraldo-netto wants to merge 2 commits into
Conversation
Several teardown and error paths could raise before doing their work: - DhcpClient: self._client was undefined until run(), so _check_client() and _on_timeout() raised AttributeError if reached early. Initialise it to None and bail out when there is no client. Also fix the timeout check: poll() returning 0 (a clean exit) was treated like "still running" via `not poll()`; only terminate when poll() is None. - mechanism Network: EnableNetwork indexed DHCPDHANDLERS with the caller's string, raising KeyError on an unknown handler. Validate the key and raise a clear ValueError before touching NetConf. - NetConf: DHCPHandler.clean_up() used next() without a default, so an empty match raised StopIteration and aborted the rest of cleanup. Supply a default. - Rfcomm: OpenRFCOMM now logs and re-raises if spawning the watcher fails instead of failing opaquely. Add unit + fuzz coverage for each guard. Tests need no D-Bus or display. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several teardown and error paths could raise before doing their work:
not poll(); only terminate when poll() is None.Add unit + fuzz coverage for each guard. Tests need no D-Bus or display.