fix: route DHCP renew through AppletDhcpClientService proxy#3288
Open
geraldo-netto wants to merge 1 commit into
Open
fix: route DHCP renew through AppletDhcpClientService proxy#3288geraldo-netto wants to merge 1 commit into
geraldo-netto wants to merge 1 commit into
Conversation
NetworkService.common_actions called AppletService().dchp_client(), but the dchp_client method lives on the org.blueman.Applet.DhcpClient interface, exposed by AppletDhcpClientService — AppletService has no such method, so the "Renew IP Address" action raised AttributeError at call time. This also gives AppletDhcpClientService a real production call site. Add unit + fuzz coverage: - AppletDhcpClientService.dchp_client dispatches the correct method name and object-path variant; valid paths forwarded verbatim, malformed object paths rejected by GLib before any D-Bus call. - NetworkService renew action dispatches to AppletDhcpClientService with the device object path; regression guard that AppletService is not referenced. - Guard that AppletStatusIconService remains a ProxyBase subclass: it is a signal-only proxy required in Tray.py to receive StatusIcon-interface signals, so it must not be removed. Tests avoid dbusmock so they run without a live bus. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkService.common_actions called AppletService().dchp_client(), but the dchp_client method lives on the org.blueman.Applet.DhcpClient interface, exposed by AppletDhcpClientService — AppletService has no such method, so the "Renew IP Address" action raised AttributeError at call time. This also gives AppletDhcpClientService a real production call site.
Add unit + fuzz coverage:
Tests avoid dbusmock so they run without a live bus.