Skip to content

fix(app): apply requested changes to settings page - #159

Open
squeaky-duck-duck wants to merge 34 commits into
bluelearn-org:mainfrom
squeaky-duck-duck:fix/settings-page-1
Open

fix(app): apply requested changes to settings page#159
squeaky-duck-duck wants to merge 34 commits into
bluelearn-org:mainfrom
squeaky-duck-duck:fix/settings-page-1

Conversation

@squeaky-duck-duck

Copy link
Copy Markdown

Summary

  • Fix editor autosave dropping last edits: debounced localStorage write missed pending changes on unmount/tab close; now cache latest markdown in a ref and flush immediately on unmount and beforeunload.
  • Restore settings.tsx to working state: prior version had an undefined handleSave reference, and styling that does not match the project
  • Rewire settings form to controlled inputs (displayName/username/bio state) with saving/saveError state, handleSave posting to client.me.$patch, and disabled state on the button during save.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Build / tooling / CI
  • Other: _________

Verification

  • pnpm -r typecheck passes
  • pnpm -r build passes
  • Manually verified in a browser (for UI / behavior changes)
  • Followed the app layout conventions
  • No new dependencies, or new dependencies are justified and AGPL-compatible
  • Change does not violate any non-negotiable principle
  • Documentation only, no changes to the codebase, so no tests required

@squeaky-duck-duck squeaky-duck-duck changed the title fix(app): apply requested changes to /settings fix(app): apply requested changes to /settings (closes #50) Jul 20, 2026
@andyrodrigues30 andyrodrigues30 changed the title fix(app): apply requested changes to /settings (closes #50) fix(app): apply requested changes to /settings Jul 20, 2026
@andyrodrigues30 andyrodrigues30 linked an issue Jul 20, 2026 that may be closed by this pull request
1 task

@andyrodrigues30 andyrodrigues30 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See contribution flow screen - use same styling and structure - don't use the exact StepperActionHeader component for the title of the pages but use the same styling and use only one Button - cta-pri for save button.

Image

Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Comment thread app/src/routes/settings.tsx Outdated
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
@andyrodrigues30 andyrodrigues30 removed a link to an issue Jul 22, 2026
1 task
@squeaky-duck-duck
squeaky-duck-duck marked this pull request as draft July 28, 2026 08:46
@squeaky-duck-duck
squeaky-duck-duck marked this pull request as ready for review July 28, 2026 09:02
@andyrodrigues30 andyrodrigues30 changed the title fix(app): apply requested changes to /settings fix(app): apply requested changes to settings page Jul 28, 2026
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 28, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
blue-api f8d58fd Jul 29 2026, 08:03 PM

Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
andyrodrigues30 and others added 16 commits July 28, 2026 23:11
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: Tonycs <lam.tony540@gmail.com>
Signed-off-by: Tonycs <lam.tony540@gmail.com>
Signed-off-by: Tonycs <lam.tony540@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: Tonycs <lam.tony540@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
Signed-off-by: Tonycs <lam.tony540@gmail.com>
Signed-off-by: andyrodrigues30 <andrea.melissa.rodrigues@gmail.com>
@andyrodrigues30 andyrodrigues30 added the area:frontend Tasks related to frontend (app) label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Tasks related to frontend (app)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants