Skip to content

Add nullptr check in logCertVerificationFailure - #93

Open
thisisnsh wants to merge 1 commit into
mainfrom
fix-cert-verification-null-check
Open

Add nullptr check in logCertVerificationFailure#93
thisisnsh wants to merge 1 commit into
mainfrom
fix-cert-verification-null-check

Conversation

@thisisnsh

Copy link
Copy Markdown
Contributor

Problem statement

  • In logCertVerificationFailure following pointers were not null checked before accessing them:
    • X509_STORE_CTX cert context
    • X509 cert
    • X509_NAME subject name

Proposed changes

  • In logCertVerificationFailure check pointers are not null before accessing them
  • Add tests
  • Add error code, message and depth to log for better debugging

Remaining work

  • Unit Tests
  • Integration Tests
  • Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant