Skip to content

Use prek for linting - #192

Open
mylee04 wants to merge 1 commit into
bloomberg:mainfrom
mylee04:agent/use-prek-for-linting
Open

Use prek for linting#192
mylee04 wants to merge 1 commit into
bloomberg:mainfrom
mylee04:agent/use-prek-for-linting

Conversation

@mylee04

@mylee04 mylee04 commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • add a pre-commit configuration that preserves the existing Ruff and Black versions and checks
  • use prek as the lint and formatting driver while keeping mypy as a separate check
  • document the development environment and hook installation workflow

Why

Using prek keeps the lint workflow aligned with Memray while isolating Ruff and Black in hook environments. The prek executable is invoked directly so the lint job continues to work on the project's supported Python 3.8 environment.

Validation

  • tox -e lint with Python 3.8.20
  • make format
  • make lint
  • make check (98 passed, 6 skipped on Python 3.12)
  • prek validate-config .pre-commit-config.yaml
  • prek install in a temporary checkout

Closes #178

Signed-off-by: Myles Lee <myungeun2dc@gmail.com>
@mylee04
mylee04 marked this pull request as ready for review August 13, 2026 23:28
@mylee04

mylee04 commented Aug 13, 2026

Copy link
Copy Markdown
Author

Hi @godlygeek, this is ready for review when you have a chance. The GitHub Actions workflows are also awaiting maintainer approval to run. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to using prek for linting

1 participant