artifact: fix the-exploit-floor (detail panel blank on zone select) - #167
Merged
Conversation
The detail panel is hidden by `.ef-panel-detail { display: none }`, but
showDetail() revealed it with `style.display = ''`. An empty string clears
the inline style, so the element fell back to the class rule and stayed
hidden — and since the default panel is also hidden on select, the whole
panel went blank. Set an explicit `display: 'block'` to override the rule.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01THWkDxQzDdyiEbzyRP5NF3
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blokzdev
enabled auto-merge (squash)
June 24, 2026 03:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the
the-exploit-floorartifact, clicking a zone in the chart should swap the side panel from the default legend/benchmark view to a per-zone detail (threat model + recommended defense + stats). Instead the panel went blank — in both inline and fullscreen.Root cause
The detail container is hidden by default via a CSS class:
.ef-panel-detail { display: none }.showDetail()revealed it withpanelDetail.style.display = ''— but an empty string removes the inline style, so the element falls back to the class rule and staysdisplay: none. SinceshowDetail()also hides the default panel, both children end up hidden → blank panel.It slipped QA because the default panel renders fine on load; only the click-triggered detail was broken.
Fix
One line in
showDetail():An explicit
blockoverrides the class rule.showDefault()already worked (the default panel has no competingdisplayrule).Scope
Not systemic — I checked all 8
style.display = ''sites acrosssrc/islands/artifacts/; the others toggle default-visible elements (correct usage), andthe-fault-quadrantreveals its detail via a dedicated.tfq-showclass.the-exploit-floorwas the only one pairing a class-leveldisplay:nonewith a''reveal.Verification
npm run check && npm run buildpass.🤖 Generated with Claude Code
Generated by Claude Code