Skip to content

artifact: fix the-exploit-floor (detail panel blank on zone select) - #167

Merged
blokzdev merged 2 commits into
mainfrom
claude/fix-exploit-floor-panel
Jun 24, 2026
Merged

artifact: fix the-exploit-floor (detail panel blank on zone select)#167
blokzdev merged 2 commits into
mainfrom
claude/fix-exploit-floor-panel

Conversation

@blokzdev

Copy link
Copy Markdown
Owner

Problem

In the the-exploit-floor artifact, clicking a zone in the chart should swap the side panel from the default legend/benchmark view to a per-zone detail (threat model + recommended defense + stats). Instead the panel went blank — in both inline and fullscreen.

Root cause

The detail container is hidden by default via a CSS class: .ef-panel-detail { display: none }. showDetail() revealed it with panelDetail.style.display = '' — but an empty string removes the inline style, so the element falls back to the class rule and stays display: none. Since showDetail() also hides the default panel, both children end up hidden → blank panel.

It slipped QA because the default panel renders fine on load; only the click-triggered detail was broken.

Fix

One line in showDetail():

- panelDetail.style.display = '';
+ panelDetail.style.display = 'block';

An explicit block overrides the class rule. showDefault() already worked (the default panel has no competing display rule).

Scope

Not systemic — I checked all 8 style.display = '' sites across src/islands/artifacts/; the others toggle default-visible elements (correct usage), and the-fault-quadrant reveals its detail via a dedicated .tfq-show class. the-exploit-floor was the only one pairing a class-level display:none with a '' reveal.

Verification

  • npm run check && npm run build pass.
  • Locally: clicking each zone (Below Floor / Danger Zone / Audit-Viable) now renders the detail (title, TVL range, description, recommended defense, and the stat grid for danger/audit-viable); "← All zones" returns to the default view; works inline and fullscreen.

🤖 Generated with Claude Code


Generated by Claude Code

The detail panel is hidden by `.ef-panel-detail { display: none }`, but
showDetail() revealed it with `style.display = ''`. An empty string clears
the inline style, so the element fell back to the class rule and stayed
hidden — and since the default panel is also hidden on select, the whole
panel went blank. Set an explicit `display: 'block'` to override the rule.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01THWkDxQzDdyiEbzyRP5NF3
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blokz Ready Ready Preview, Comment Jun 24, 2026 4:04am

@blokzdev
blokzdev enabled auto-merge (squash) June 24, 2026 03:59
@blokzdev
blokzdev merged commit 85b0bb4 into main Jun 24, 2026
2 of 3 checks passed
@blokzdev
blokzdev deleted the claude/fix-exploit-floor-panel branch June 24, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants