You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactors search bar dropdown positioning to use Chakra Popover's built-in sameWidth positioning instead of manually tracking input width with a ResizeObserver.
Proposed Changes
Remove manual ResizeObserver + debounced width calculation from SearchBarDesktop and SearchResultsInput
Use Popover positioning.sameWidth: true so the suggest/recent-keywords menu matches the trigger width
Simplify PopoverContent width styling (w="auto", maxW="100%") and drop the menuWidth ref
Restore input focus when selecting a recent keyword in the desktop search bar (handleRecentKeywordsClick)
Breaking or Incompatible Changes
None.
Additional Information
Net reduction of ~40 lines of layout-sync logic. Behavior should be unchanged aside from the recent-keywords focus fix on desktop.
Checklist for PR author
I have tested these changes locally.
I added tests to cover any new functionality, following this guide
Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
If I have added a feature or functionality that is not privacy-compliant (e.g., tracking, analytics, third-party services), I have disabled it for private mode.
If I have added, changed, renamed, or removed an environment variable
I updated the list of environment variables in the documentation
I made the necessary changes to the validator script according to the guide
Auto reviews are disabled on this repository. To trigger a review, include @coderabbitai review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 0b1b34e9-74f8-41b0-b30a-04d2c35d62f8
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
Refactors search bar dropdown positioning to use Chakra Popover's built-in
sameWidthpositioning instead of manually tracking input width with a ResizeObserver.Proposed Changes
ResizeObserver+ debounced width calculation fromSearchBarDesktopandSearchResultsInputpositioning.sameWidth: trueso the suggest/recent-keywords menu matches the trigger widthPopoverContentwidth styling (w="auto",maxW="100%") and drop themenuWidthrefhandleRecentKeywordsClick)Breaking or Incompatible Changes
None.
Additional Information
Net reduction of ~40 lines of layout-sync logic. Behavior should be unchanged aside from the recent-keywords focus fix on desktop.
Checklist for PR author