fix: make bundled skill frontmatter discoverable - #299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Category: fix
User Impact: Agents can discover the installed Ghost skill instead of silently skipping its malformed metadata.
Problem: The bundled skill and schema-reference descriptions contain unquoted
:in YAML frontmatter. On current main, installation andghost skill checksucceed because the bytes match the bundle, but the real Goose skill loader omitsghostbecause its metadata does not parse.Solution: Encode both descriptions as folded YAML scalars, preserving their text and the newer main guidance. Add installed-bundle parsing tests and an opt-in test against the real host discovery loader. This complements #294's file-integrity check; it does not change that command's contract.
File changes
packages/ghost/src/skill-bundle/SKILL.md
Make the description valid YAML without changing its value or the skill instructions.
packages/ghost/src/skill-bundle/references/schema.md
Fix the same metadata encoding issue in the bundled schema reference.
packages/ghost/test/skill-bundle.test.ts
Reproduce the malformed header and validate the installed skill's metadata and bundled reference frontmatter.
packages/ghost/test/goosed-skill-discovery.test.ts
With
GOOSE_BINset, verify that the real loader rejects malformed metadata and discovers the installed fixed skill in an isolated workspace/profile. Ordinary test runs skip this host-dependent test..changeset/fix-ghost-skill-frontmatter.md
Record a patch release for the discovery fix.
Verification
Validated against main
7cc2e21d:ghost skill checkstill passed as intended.pnpm buildandpnpm checkpass.GOOSE_BIN=/path/to/goosed.A separate natural-agent workflow smoke was blocked by authentication before any model work. This PR verifies parsing and discovery, not autonomous workflow invocation. No Berd implementation, evaluation data, or session logs are included.