Centralize protobuf scalar initialization#1313
Merged
Merged
Conversation
myronmarston
approved these changes
Jul 20, 2026
myronmarston
left a comment
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
Can you apply this same pattern to elasticgraph-json_ingestion? It could be improved in the same way:
jwils
marked this pull request as ready for review
July 20, 2026 19:59
jwils
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwondrusch,
marcdaniels-toast and
rossroberts-toast
as code owners
July 20, 2026 19:59
jwils
added a commit
that referenced
this pull request
Jul 21, 2026
## Why Built-in JSON scalar defaults and final JSON Schema validation are split between the factory and scalar extension. ## What - Centralize built-in JSON Schema mappings and initialization in `ScalarTypeExtension`. - Keep the factory responsible only for extending the scalar and forwarding its configuration block. - Preserve the existing default, user configuration, runtime metadata, and validation order, including renamed built-in scalars. ## Validation - `script/run_gem_specs elasticgraph-json_ingestion` - `script/lint elasticgraph-json_ingestion` - `script/type_check` ## Risk assessment Low. This is a structural refactor that preserves existing JSON scalar configuration behavior. ## References - #1313 (review) - Follow-up to #1313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Built-in scalar defaults and final protobuf validation are split between the factory and scalar extension.
What
ScalarTypeExtension.Validation
script/run_gem_specs elasticgraph-proto_ingestionscript/lint elasticgraph-proto_ingestionscript/type_checkRisk assessment
Low. This is a structural refactor that preserves existing scalar configuration behavior.
References