Skip to content

Add unit test for Relationship#parent_relationship to_final_form handling #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellisandrews-toast merged 3 commits into from
Jul 20, 2026
Merged

Add unit test for Relationship#parent_relationship to_final_form handling #1310

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e2ba8e
Add unit test for Relationship#parent_relationship to_final_form hand…
ellisandrews-toast Jul 15, 2026
bb12af8
Merge remote-tracking branch 'origin/main' into relationship-to-final…
ellisandrews-toast Jul 20, 2026
ffbf64e
Move to_final_form coverage into update_targets_spec per review feedback
ellisandrews-toast Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...stic_graph/schema_definition/runtime_metadata/object_types_by_name/update_targets_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,6 +1501,12 @@ def raise_error_about_workspace_relationship(details, sourced_fields: true)
expect_statline_update_target_with(metadata)
end

it "resolves the parent type by its overridden name when `type_name_overrides` renames it" do
metadata = nested_sourced_from_schema(type_name_overrides: {"Team" => "RenamedTeam"})

expect_statline_update_target_with(metadata, type: "RenamedTeam")
end

it "discovers an embedding field declared with `indexing_only: true`" do
# An `indexing_only: true` field is absent from `graphql_fields_by_name` but present in
# `indexing_fields_by_name_in_index`, so this only resolves when the latter is used.
Expand Down Expand Up @@ -1917,6 +1923,7 @@ def nested_update_targets_by_relationship(metadata)
def expect_statline_update_target_with(
metadata,
relationship: "players.statLine",
type: "Team",
routing_value_source: nil,
rollover_timestamp_value_source: nil,
field_params: {"goals" => dynamic_param_with(source_path: "goals", cardinality: :one)},
Expand All @@ -1926,7 +1933,7 @@ def expect_statline_update_target_with(
expect(targets.keys).to contain_exactly(relationship)

target = targets.fetch(relationship)
expect(target.type).to eq "Team"
expect(target.type).to eq type
expect(target.relationship).to eq relationship
expect(target.script_id).to eq(INDEX_DATA_UPDATE_SCRIPT_ID)
expect(target.id_source).to eq "teamId"
Expand Down Expand Up @@ -1954,10 +1961,11 @@ def nested_sourced_from_schema(
player_goals_type: "Int",
player_goals_source: "goals",
player_statline_dir: :in,
player_statline_via: "playerId"
player_statline_via: "playerId",
type_name_overrides: {}
)
# `StatLine` is the source type, so its metadata carries the nested update targets we assert on.
object_type_metadata_for "StatLine" do |s|
object_type_metadata_for "StatLine", type_name_overrides: type_name_overrides do |s|
if embed_players_under
s.object_type s.state.type_ref(embed_players_under).fully_unwrapped.name do |t|
t.field "players", players_field do |f|
Expand Down