Skip to content

Improve admin mapping change output#1206

Merged
jwils merged 1 commit into
mainfrom
joshuaw/hide-delete-changes-admin-lambda
Jul 9, 2026
Merged

Improve admin mapping change output#1206
jwils merged 1 commit into
mainfrom
joshuaw/hide-delete-changes-admin-lambda

Conversation

@jwils

@jwils jwils commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move mapping-removal noise handling into elasticgraph-admin so all admin users benefit.
  • Preserve current mapping fields in index update payloads and diffs--for concrete indices and index templates--hiding unsupported/unsafe field removals while still showing new fields and mapping parameter changes.
  • Keep settings diffs complete, and report new index templates as created instead of dumping the full config diff.

This is purely an output improvement: no behavior changes. Index templates keep preserving fields that have been removed from the schema (as they always have); the removals just no longer clutter every admin run's diff. Actually dropping stale template fields safely is implemented separately in the stacked PR #1303, per review feedback.

Context

Mapping removals are unsupported by Elasticsearch/OpenSearch concrete indices, so showing removed fields every admin run just makes the diffs harder to read. Index templates technically allow field removal, but dropping a field that an older deployed indexer can still write causes indexing failures on new rollover indices (mappings are dynamic: strict), so templates keep their existing fields and the removals are likewise hidden from the diff output.

This addresses #766 and the review feedback to improve elasticgraph-admin directly instead of adding an elasticgraph-admin_lambda opt-in.

Verification

  • script/lint
  • script/spellcheck
  • script/type_check
  • script/quick_build

@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from 7123aca to 37b0486 Compare May 22, 2026 23:02
myronmarston

This comment was marked as resolved.

@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from 37b0486 to c6e3e1f Compare May 22, 2026 23:43
@jwils jwils changed the title Hide delete changes in admin lambda output Improve admin mapping change output May 22, 2026
@jwils
jwils marked this pull request as ready for review May 22, 2026 23:49
@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from c6e3e1f to a9a165f Compare May 23, 2026 00:06
@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from a9a165f to c72908c Compare June 16, 2026 22:54
@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from c72908c to a335f6c Compare June 17, 2026 17:40
@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from 2e5fc2b to fcba5e2 Compare July 1, 2026 18:15
@ellisandrews-toast ellisandrews-toast self-assigned this Jul 8, 2026

@ellisandrews-toast ellisandrews-toast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. Only one small comment about whether to enhance user-facing output so the riskiest part is at least explicitly called out.

@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from f4c3b72 to 9afb666 Compare July 8, 2026 19:44
@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from 9afb666 to 2b3c876 Compare July 8, 2026 20:39
@jwils
jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from 2b3c876 to bc2d25d Compare July 8, 2026 21:33
@jwils
jwils merged commit a9222aa into main Jul 9, 2026
24 checks passed
@jwils
jwils deleted the joshuaw/hide-delete-changes-admin-lambda branch July 9, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants