Improve admin mapping change output#1206
Merged
Merged
Conversation
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
May 22, 2026 23:02
7123aca to
37b0486
Compare
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
May 22, 2026 23:43
37b0486 to
c6e3e1f
Compare
jwils
marked this pull request as ready for review
May 22, 2026 23:49
jwils
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo and
jwondrusch
as code owners
May 22, 2026 23:49
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
May 23, 2026 00:06
c6e3e1f to
a9a165f
Compare
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
June 16, 2026 22:54
a9a165f to
c72908c
Compare
jwils
requested review from
ellisandrews-toast,
marcdaniels-toast and
rossroberts-toast
as code owners
June 16, 2026 22:54
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
June 17, 2026 17:40
c72908c to
a335f6c
Compare
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
July 1, 2026 18:15
2e5fc2b to
fcba5e2
Compare
ellisandrews-toast
left a comment
Collaborator
There was a problem hiding this comment.
The implementation looks good to me. Only one small comment about whether to enhance user-facing output so the riskiest part is at least explicitly called out.
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
July 8, 2026 19:44
f4c3b72 to
9afb666
Compare
myronmarston
requested changes
Jul 8, 2026
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
July 8, 2026 20:39
9afb666 to
2b3c876
Compare
myronmarston
requested changes
Jul 8, 2026
jwils
force-pushed
the
joshuaw/hide-delete-changes-admin-lambda
branch
from
July 8, 2026 21:33
2b3c876 to
bc2d25d
Compare
myronmarston
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elasticgraph-adminso all admin users benefit.This is purely an output improvement: no behavior changes. Index templates keep preserving fields that have been removed from the schema (as they always have); the removals just no longer clutter every admin run's diff. Actually dropping stale template fields safely is implemented separately in the stacked PR #1303, per review feedback.
Context
Mapping removals are unsupported by Elasticsearch/OpenSearch concrete indices, so showing removed fields every admin run just makes the diffs harder to read. Index templates technically allow field removal, but dropping a field that an older deployed indexer can still write causes indexing failures on new rollover indices (mappings are
dynamic: strict), so templates keep their existing fields and the removals are likewise hidden from the diff output.This addresses #766 and the review feedback to improve
elasticgraph-admindirectly instead of adding anelasticgraph-admin_lambdaopt-in.Verification
script/lintscript/spellcheckscript/type_checkscript/quick_build