feat(pairing): support explicit interop payloads#1840
Draft
brow wants to merge 1 commit into
Draft
Conversation
Add paired payload type and content flags while preserving the existing nsec behavior. Document the Buzz workspace payload shape and cover argument validation and verbatim interop payload handling. Co-authored-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1ux8n2yfs8qfvgd75s7kyhar2mztac355v6vmrz4juc9l3msw4pgstums9e <e18f3511303812c437d487ac4bf46ad897dc46946699b18ab2e60bf8ee0ea851@sprout-oss.stage.blox.sqprod.co>
Contributor
Author
|
@codex review |
Contributor
Author
|
@builderbot review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add paired
--payload-typeand--payloadoptions tobuzz-pair source, allowing the generic NIP-AB interop CLI to sendnsec,bunker,connect, or application-definedcustompayloads verbatim.The existing raw-
nsecbehavior remains the default. The README now includes a Buzz workspace payload example and distinguishes its HTTP API URL from the WebSocket pairing relay.Why?
This lets the conformance tool impersonate application-specific pairing sources, including Buzz desktop, without baking a Buzz-only schema into the CLI or changing compatibility for existing users.
How is it tested?
Rust formatting, focused unit tests, and Clippy pass. The required pre-push suite passed Rust, desktop, and desktop Tauri checks; its workspace integration phase hit the two existing environment-sensitive
buzz-authkeyfile failures (missing_keyandbad_keyfile_permissions). The deep dual pre-review loop completed with no actionable findings.Added tests:
--nsecconflicts--nsecbehavior