fix(desktop): prevent menu-to-dialog UI lockups#1839
Merged
Conversation
wesbillman
force-pushed
the
pinky/fix-menu-dialog-lockup
branch
from
380c99c to
d36f173
Compare
Make menu roots non-modal where their actions hand off to dialogs so Radix cannot leave the body's pointer-events guard behind. Cover the workspace rail outside-dismiss flow with an end-to-end regression test. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
pinky/fix-menu-dialog-lockup
branch
from
5e1863d to
560e15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A modal Radix menu and a dialog can overlap during the handoff. Both manage the global pointer-events guard, and dismissing the dialog outside can leave
pointer-events: noneon<body>, making the app unclickable. Non-modal menus avoid installing that competing body guard.Test plan
pnpm exec biome checkon changed filespnpm typecheckpnpm buildpnpm exec playwright test tests/e2e/workspace-rail.spec.ts(7 passed)