fix(desktop): retain live rows in exhausted windows#1813
Closed
wesbillman wants to merge 1 commit into
Closed
Conversation
A complete short channel window has no unloaded older boundary. Preserve same-second live rows there even when their event id sorts beyond the current oldest row; otherwise valid messages are silently discarded. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live top-level events could disappear before scrolling began when a short channel's first page was already exhausted.
mergeLiveChannelWindowEventcompared a same-second event's Nostr ID against the oldest loaded row and discarded it as below the retained boundary, even whenhasMore=falsemeant no unloaded boundary existed.hasMore=true).This is separate from #1802: that PR fixed a refresh/cache overwrite race; this fixes event loss at the live-window boundary. It keeps the existing scroll contracts intact and does not increase timeouts or retries.
Validation
Local real-relay E2E repetition could not run because no relay was listening on
localhost:3000; CI should provide the integration signal. Several consecutive integration/scroll-shard passes are still required before treating the recurring missing-seed signature as stabilized.