Skip to content

Right-size notification fixtures and stabilize thread-navigation coverage #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 2 commits into from
Sep 16, 2026
+17 −8
Merged

Right-size notification fixtures and stabilize thread-navigation coverage #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ee37f
Generate only the notification histories the browser journeys need
comp615 Sep 14, 2026
4c5c919
Make thread-history navigation independent of unread badge timing
comp615 Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions tests/browser/navigation-thread-history.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,21 @@ test("Back restores each thread visit before the previous channel", async ({
page,
app,
}) => {
await open(page, app);
const beta = page
.getByRole("navigation", { name: "Subscribed channels" })
.locator('button[data-channel-id="beta"]');
app.relay.holdUnread();
try {
await open(page, app);
await expect.poll(() => app.report.unreadHolds.length).toBe(1);
await expect(beta).toHaveAccessibleName("Beta");
} finally {
app.relay.releaseUnread();
}
// Unread evidence changes the accessible name independently of navigation.
await expect(beta.getByRole("img")).toHaveAccessibleName(
"20 observed unread messages. Not an exact total.",
);
const roots = app.histories
.get("primary/alpha")
.filter((row) => row.content.startsWith("Thread root"));
Expand Down Expand Up @@ -36,7 +50,7 @@ test("Back restores each thread visit before the previous channel", async ({
);
await expect(panel.getByText("Thread root 1", { exact: true })).toBeVisible();
expect(await openThread.evaluate((node) => node.isConnected)).toBe(true);
await page.getByRole("button", { name: "Beta", exact: true }).click();
await beta.click();
await expect(
page.getByRole("textbox", { name: "Message #Beta", exact: true }),
).toBeVisible();
Expand Down
7 changes: 1 addition & 6 deletions tests/browser/notifications.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ test.use({
readState: true,
threadUnread: true,
pluginFixtures: true,
historyCounts: { alpha: 20, beta: 1 },
});

// Only the browser's OS boundary is replaced. The built host, session,
Expand Down Expand Up @@ -240,12 +241,6 @@ for (const kind of ["mention", "thread reply"]) {
}) => {
// Model a real prior contribution in relay history, not a client-side
// participation/readiness override. The incoming reply itself has no p tag.
// Keep this prior contribution inside the existing 500-event unread
// evidence window; the default 640-row Alpha fixture would crowd it out.
app.histories.set(
"primary/alpha",
app.histories.get("primary/alpha").slice(-200),
);
const root =
kind === "thread reply"
? app.append("primary", "beta", "My prior thread", false)
Expand Down
Loading