Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5d99cac96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
repalash
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65b95ee283
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92570fc122
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ed9c36146
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,22 @@ | |||
| // Only untouched references to the baked, untextured asset kit may use simplified batching. | |||
| export function isGeneratedPlacement(node, placement, registry) { | |||
| if (!placement?.baked || !node.visible) return false | |||
There was a problem hiding this comment.
When a user attaches a movement, animation, or physics component to an otherwise untouched generated placement, the component keeps updating the placement node while main.js snapshots its child meshes' world matrices once and then hides those meshes, so the visible batch remains frozen. The fresh case not covered by bakedMeshes' descendant filtering is a component on the placement node itself; reject nodes with EntityComponentPlugin from batching or synchronize their batch transforms.
AGENTS.md reference: examples/sf-city/AGENTS.md:L144-L145
Useful? React with 👍 / 👎.
| @@ -0,0 +1,22 @@ | |||
| // Only untouched references to the baked, untextured asset kit may use simplified batching. | |||
| export function isGeneratedPlacement(node, placement, registry) { | |||
| if (!placement?.baked || !node.visible) return false | |||
There was a problem hiding this comment.
When a user hides a generated tile group or the city root while its child placements retain their default visible: true, modelRoot.traverse still visits those descendants and this check tests only the child. main.js then copies their meshes into a runtime root outside the hidden ancestor, causing the entire hidden subtree to reappear during Play; require effective ancestor visibility or use visible-only traversal.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed0a3e103d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| runtime.add(sun) | ||
| const ownedAO = !viewer.getPlugin(SSAOPlugin) | ||
| const ao = ownedAO ? await viewer.addPlugin(SSAOPlugin) : viewer.getPlugin(SSAOPlugin) |
There was a problem hiding this comment.
When viewer.addPlugin(SSAOPlugin) rejects during Play startup, such as during unsupported renderer or plugin initialization, execution reaches finally with started === false, but that path only disposes the material pool and environment. The generated city lights have already been reduced to 25% intensity and owned geometry has been allocated, so no cleanup function is returned to restore them; the editor remains dim after the failed Play, repeated attempts compound the intensity reduction, and geometry leaks. Roll back every acquired runtime resource and mutation on this failure path.
AGENTS.md reference: examples/sf-city/AGENTS.md:L64-L64
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44b50c3d00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| next.extras = {...old.extras, ...values.extras, gltfUUID: old.extras?.gltfUUID || uuid(id), cityId: id, | ||
| cityGenerated: {...values, extras: undefined, rootPath: values.extras?.rootPath}} |
There was a problem hiding this comment.
When an editor or plugin adds its own key under an existing node's extras.city object, this shallow spread replaces the entire object with the generated values.extras.city, silently deleting the unowned nested metadata on the next city:build. Merge the generated city fields into the existing object just as the light extension is merged.
AGENTS.md reference: examples/sf-city/AGENTS.md:L126-L126
Useful? React with 👍 / 👎.
| widthSource: p.widthSource, species: p.species, sourceHash: p.sourceHash}}}) | ||
| ;(groups[p.tile] ||= []).push(index) | ||
| } | ||
| const groupIndices = Object.keys(groups).sort().map((tile) => upsert(`sf-tile:${tile}`, {name: `Tile ${tile}`, children: groups[tile]})) |
There was a problem hiding this comment.
When a user reparents a generated placement in the editor, the new parent's children still contains that node index, while this upsert unconditionally adds the same index back to its generated tile. The resulting glTF assigns one node to two parents; loaders may reparent it according to traversal order, so either the user's group or the generated tile loses the object after rebuilding. Remove the index from other parents when restoring generated membership, or preserve the edited parent.
Useful? React with 👍 / 👎.
Adds an offline, editable North Beach / Washington Square slice: 419 buildings, 74 streets and 191 mapped trees from four DataSF snapshots. Stable feature IDs, local overrides and generated glTF assets let individual objects improve without rebuilding the project from scratch.
Street surfaces now clip overlapping corridors, remove sidewalks crossing carriageways, add 15 cm curb faces and lowered crossing approaches, and cut the rendered ground beneath streets to prevent terrain poke-through. These curb shapes remain procedural; terrain still interpolates older city ground samples, and facades/trees remain placeholders.
Regeneration preserves user asset registrations and replacements, unknown light extensions, placement edits and extras. The example declares its direct threepipe dependency without upgrading the pinned engine. A standalone runtime export includes only intended demo assets; no hosted release has been published yet.
README and limitations · Before · After
Validation (implementation 026f8e1; preservation follow-up 65b95ee):
Remaining quality work: datum-aligned LiDAR terrain, building-front corridor fitting and rounded surveyed curb returns, authored SF facades/landmarks, runtime collision and production LOD/streaming. Screenshot rates are not a measured performance budget.