fix(runtime): break divert target reference cycles - #32
Merged
Merged
Conversation
Co-authored-by: Brent Anderson <me@brentjanderson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rc<Container>held byDivertwith aWeak<Container>plus the target indexContext
This supersedes #23 and retains Brent Anderson’s original diagnosis and core
Weak-cache approach. The implementation has been ported to the currentruntime/workspace layout and updated for the repository’s current formatting and Clippy requirements.The original allocator-based regression test ran 1,000 full stories, took roughly 9–13 seconds locally, and retained about 667 MB when demonstrating the failure. The replacement test checks the ownership invariant directly, avoids a global unsafe allocator, and completes immediately.
Validation
cargo fmt --allcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspacecargo test -p bladeink --features stream-json-parser